[dpdk-dev] [PATCH 0/6] examples/ipsec-secgw: fix 1st pkt dropped
Iremonger, Bernard
bernard.iremonger at intel.com
Thu Mar 7 11:06:40 CET 2019
Hi Akhil,
<snip>
> Subject: Re: [dpdk-dev] [PATCH 0/6] examples/ipsec-secgw: fix 1st pkt dropped
>
> Hi Bernard,
>
> On 3/6/2019 9:30 PM, Bernard Iremonger wrote:
> > This patchset fixes the issue of the first inbound packet being
> > dropped for inline crypto. It also improves the debug output in esp.c,
> > sa.c and ipsec-secgw.c
> >
> > Bernard Iremonger (6):
> > examples/ipsec-secgw: fix 1st pkt dropped for inline crypto
> > examples/ipsec-secgw: fix 1st packet dropped patch two
> > examples/ipsec-secgw: fix 1st packet dropped patch three
> patch titles are not good. You can probably add some logical comments in the
> description.
I will update the patch titles and descriptions.
> you may also consider squashing the patches if no logical bifurcation can be
> made.
I thought it might be easier to review the changes as separate patches.
If you prefer one patch I can squash them.
> > examples/ipsec-secgw: fix debug in esp.c
> > examples/ipsec-secgw: fix debug in sa.c
> > examples/ipsec-secgw: fix debug in ipsec-secgw.c
> Above 3 patches can be squashed and can be separated from this series.
I will remove from this patch set, squash and send as an independent patch.
> > examples/ipsec-secgw/esp.c | 5 +-
> > examples/ipsec-secgw/ipsec-secgw.c | 252 ++++++++++++++++++------------
> -----
> > examples/ipsec-secgw/ipsec.c | 123 +++++++++++------
> > examples/ipsec-secgw/ipsec.h | 5 +-
> > examples/ipsec-secgw/ipsec_process.c | 9 +-
> > examples/ipsec-secgw/sa.c | 67 ++++++++--
> > 6 files changed, 274 insertions(+), 187 deletions(-)
> >
Regards,
Bernard.
More information about the dev
mailing list