[dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

[Thomas Monjalon]

13/03/2019 19:32, Ferruh Yigit:
> On 3/5/2019 7:11 AM, Hyong Youb Kim wrote:
> > The driver currently has a devarg to set the rewrite mode during
> > init. Some apps want to programatically set it after running
> > rte_eal_init() and finding that ports are VIC. Add a private function
> > to support such applications.
> 
> It is not good idea to have PMD specific APIs (although we already have some).
> 
> Specific to this case, as far as I can see it is to pass a config value and do
> the action related to it, what would you think having a generic key/value
> set/get API in ethdev for this? Similar to rawdev get_attr/set_attr [1]?
> 
> My concern is it may turn into something like ioctl with many things pushed to
> it, and cause possible duplication ...

Yes, it is clearly ioctl style.

Please could you explain more what is the rewrite mode?
Does it apply to the port or the queue?