[dpdk-dev] [PATCH 04/10] net/virtio: optimize flags update for packed ring

Maxime Coquelin maxime.coquelin at redhat.com
Tue Mar 19 13:50:47 CET 2019



On 3/19/19 11:11 AM, Jens Freimann wrote:
>>>
>>> same here. it's not really cached, it's pre-calculated. And here we
>>> could also use a pre-calculated constand/define.
>>
>> For pre-calculated constant/define, do you mean VRING_DESC_F_AVAIL(1)
>> and VRING_DESC_F_USED(1)? There is still little code in virtio-user
>> using them without constantly passing 1. I planned to fully get rid
>> of them in a separate patch later (but I can do it in this series if
>> anyone wants).
> 
> Yes, that's what I meant. And it's fine by me if you do it in a
> follow-up.

Agree, it can be done in a separate patch.


More information about the dev mailing list