[dpdk-dev] [EXT] Re: [PATCH v5 3/8] kvargs: adding a module definition file

[Thomas Monjalon]

26/03/2019 16:17, Bruce Richardson:
> On Tue, Mar 26, 2019 at 04:07:26PM +0100, Thomas Monjalon wrote:
> > 26/03/2019 15:41, Bruce Richardson:
> > > On Tue, Mar 26, 2019 at 02:55:41PM +0100, Thomas Monjalon wrote:
> > > > 26/03/2019 14:37, Jerin Jacob Kollanukkaran:
> > > > > On Tue, 2019-03-26 at 10:58 +0000, Bruce Richardson wrote:
> > > > > > However, my hope is that down the road we can have the def file
> > > > > > generated
> > > > > > from the map file (or potentially vice versa). Perhaps the meson
> > > > > > python
> > > > > > module could be used to allow us to script it a bit.
> > > > > 
> > > > > Make sense. Do we want to support shared lib for Windows for the first
> > > > > version? or Can we live with static lib till we find a proper solution.
> > > > > I do believe the base Windows Helloworld support needs to added this
> > > > > release in main repo and add the subsequent features step by step.
> > > > > I would treat, shared lib as subsequent feature if it is not clean.
> > > > 
> > > > I agree, shared library can be supported later.
> > > > 
> > > I would agree, except *not* supporting it will be more painful than what is
> > > proposed here. :-)
> > 
> > Why?
> > We can just document it as broken, and test only "static" compilation.
> > Am I missing something?
> > 
> Yes, static compilation also builds the shared libraries too. To turn that
> off, you'd have to modify the meson.build files to conditionally undefine
> the shared library builds on windows. Then undefine out the assignment to
> any dependency variables that are using those libraries, etc. It's doable,
> but it's a lot messier than adding in 2 .def files.

OK, thanks