[dpdk-dev] [PATCH] bnxt: fix receive VLAN offload flags

[Ferruh Yigit]

On 3/25/2019 9:34 PM, Ajit Khaparde wrote:
> On Mon, Mar 25, 2019 at 2:28 PM Stephen Hemminger <
> stephen at networkplumber.org> wrote:
> 
>> From: Stephen Hemminger <sthemmin at microsoft.com>
>>
>> The bnxt driver is not correctly setting the receive VLAN offload
>> flags. When VLAN is offloaded the driver must set the PKT_RX_VLAN_STRIPPED
>> flag.
>>
>> Actually, several drivers have the same bug, only most of the
>> Intel drivers look right. Any driver that sets vlan_tci is probably
>> stripping the tag, and should be setting RX_VLAN_STRIPPED.
>>
>> To quote rte_mbuf.h:
>>
>> /**
>>  * The RX packet is a 802.1q VLAN packet, and the tci has been
>>  * saved in in mbuf->vlan_tci.
>>  * If the flag PKT_RX_VLAN_STRIPPED is also present, the VLAN
>>  * header has been stripped from mbuf data, else it is still
>>  * present.
>>  */
>>
>> Fixes: 2eb53b134aae ("net/bnxt: add initial Rx code")
>> Signed-off-by: Stephen Hemminger <sthemmin at microsoft.com>
>>
> Acked-by: Ajit Khaparde <ajit.khaparde at broadcom.com>

Applied to dpdk-next-net/master, thanks.


In a quick glance, following PMDs as well set "PKT_RX_VLAN" but not
"PKT_RX_VLAN_STRIPPED", their maintainers are cc'ed, can you please double check:

- bnx2x
- qede (it doesn't set 'vlan_tci' if not stripped, should be fixed)
- dpaa2
- dpaa (is 'vlan_tci' set?)
- avp
- fm10k