[dpdk-dev] [PATCH 4/4] test: fix memory barrier test failure on power CPUs

David Christensen drc at linux.vnet.ibm.com
Mon May 6 20:26:26 CEST 2019


>> -#define ITER_MAX	0x100000000
>> +#define ITER_MAX	0x1000000
>
> This is a revert of a change done in patch 3.

I'll fix and resubmit.

>> @@ -92,12 +92,19 @@ struct lcore_plock_test {
>>   	other = self ^ 1;
>>
>>   	l->flag[self] = 1;
>> +#ifdef RTE_ARCH_PPC_64
>> +	rte_smp_wmb();
>> +#endif
>
> You should not have such #ifdef in a test case
> supposed to run on all architectures with the same code.
> What can be fixed in EAL?

I'll go ahead and remove the ifdefs since the code for rte_smp_wmb() 
resolves to different architecture specific code (compiler memory 
barriers in the x86 case).

Dave



More information about the dev mailing list