[dpdk-dev] [PATCH] net/mlx5: fix set VLAN id/pcp in new VLAN header

[Raslan Darawsheh]

Hi,
> -----Original Message-----
> From: dev <dev-bounces at dpdk.org> On Behalf Of Xiaoyu Min
> Sent: Friday, November 1, 2019 3:33 AM
> To: Matan Azrad <matan at mellanox.com>; Shahaf Shuler
> <shahafs at mellanox.com>; Slava Ovsiienko <viacheslavo at mellanox.com>
> Cc: dev at dpdk.org; Moti Haimovsky <motih at mellanox.com>
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix set VLAN id/pcp in new VLAN
> header
> 
> Currently if user want to set VLAN id/pcp on an about to be pushed VLAN
> header, the of_set_vlan_vid/of_set_vlan_pcp must be present _before_
> action of_push_vlan:
> 
> [1] ... actions of_set_vlan_vid vlan_vid 2 / of_push_vlan ...
> 
> This is misleading because people think rule [1] intends to set VLAN id
> on the existing VLAN header and then push one new VLAN header on top of
> it.
> 
> A more natual way to set VLAN id/pcp on an to be pushed VLAN header
> should be:
> 
> [2] ... actions of_push_vlan / of_set_vlan_vid vlan_vid 2 / ...
> 
> Fixes: a5f2da0b816b ("net/mlx5: support modify VLAN ID on new VLAN
> header")
> Fixes: 68fad3635042 ("net/mlx5: support modifying VLAN priority on VLAN
> header")
> Cc: motih at mellanox.com
> 
> Signed-off-by: Xiaoyu Min <jackmin at mellanox.com>
> ---


Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh