[dpdk-dev] [PATCH v2] vhost: fix vring message handling broken in some case

Maxime Coquelin maxime.coquelin at redhat.com
Thu Nov 14 09:52:30 CET 2019


Maybe change the title to something like:

vhost: fix vring requests validation broken if no FD in payload

On 11/13/19 12:03 PM, Zhike Wang wrote:
> When VHOST_USER_VRING_NOFD_MASK is set, the fd_num is 0,
> so validate_msg_fds() will return error. In this case,
> the negotiation of vring message between vhost user front end and
> back end would fail, and as a result, vhost user link could NOT be up.
> 
> How to reproduce:
> 1.Run dpdk testpmd insides VM, which locates at host with ovs+dpdk.
> 2.Notice that inside ovs there are endless logs regarding failure to
> handle VHOST_USER_SET_VRING_CALL, and link of vm could NOT be up.
> 
> Fixes: bf47225 ("vhost: fix possible denial of service by leaking FDs")
> Signed-off-by: Zhike Wang <wangzk320 at 163.com>
> ---
>  lib/librte_vhost/vhost_user.c | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
> 

otherwise:

Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>

The title can be changed while applying if you agree with it, no need to
send v3.

I'll take care of the different backports.

Thanks,
Maxime



More information about the dev mailing list