[dpdk-dev] [PATCH v2 5/7] drivers/net: update Rx flow flag and mark capabilities

Jerin Jacob jerinjacobk at gmail.com
Tue Oct 1 16:48:01 CEST 2019


On Thu, Aug 22, 2019 at 2:18 AM <pbhagavatula at marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula at marvell.com>
>
> Add DEV_RX_OFFLOAD_FLOW_MARK flag for all PMDs that support flow action
> flag and mark.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula at marvell.com>
> ---
> diff --git a/drivers/net/octeontx2/otx2_flow_parse.c b/drivers/net/octeontx2/otx2_flow_parse.c
> index 6670c1a70..6eb69a8b2 100644
> --- a/drivers/net/octeontx2/otx2_flow_parse.c
> +++ b/drivers/net/octeontx2/otx2_flow_parse.c
> @@ -979,7 +979,8 @@ otx2_flow_parse_actions(struct rte_eth_dev *dev,
>         if (mark)
>                 flow->npc_action |= (uint64_t)mark << 40;
>
> -       if (rte_atomic32_read(&npc->mark_actions) == 1) {
> +       if (rte_atomic32_read(&npc->mark_actions) == 1 &&

npc->mark_actions was kind of emulating the DEV_RX_OFFLOAD_FLOW_MARK.
Now that we have explicit DEV_RX_OFFLOAD_FLOW_MARK flag, We can remove
npc->mark_actions.

> +                       (hw->rx_offloads & DEV_RX_OFFLOAD_FLOW_MARK)) {
>                 hw->rx_offload_flags |=
>                         NIX_RX_OFFLOAD_MARK_UPDATE_F;
>                 otx2_eth_set_rx_function(dev);


More information about the dev mailing list