[dpdk-dev] [PATCH] app/testpmd: fix wrong return value

[Qi Zhang]

The patch fix the issue that return value in parse_vc_action_rss
be overwritten unexpectly. That cause an rte_flow creation command
with rss action does not work.

For example:

testpmd> flow create 0 ingress pattern eth / ipv4 / end \
actions rss types ipv4 end / end

We will get error "Bad Agument"

Fixes: f5267e485a2a ("app/testpmd: check status of getting ethdev info")

Reported-by: Simei Su <simei.su at intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang at intel.com>
---
 app/test-pmd/cmdline_flow.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 369426cbd..932bdb98e 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -3549,10 +3549,11 @@ parse_vc_action_rss(struct context *ctx, const struct token *token,
 	if (!port_id_is_invalid(ctx->port, DISABLED_WARN) &&
 	    ctx->port != (portid_t)RTE_PORT_ALL) {
 		struct rte_eth_dev_info info;
+		int ret2;
 
-		ret = rte_eth_dev_info_get(ctx->port, &info);
-		if (ret != 0)
-			return ret;
+		ret2 = rte_eth_dev_info_get(ctx->port, &info);
+		if (ret2 != 0)
+			return ret2;
 
 		action_rss_data->conf.key_len =
 			RTE_MIN(sizeof(action_rss_data->key),
-- 
2.13.6