[dpdk-dev] [PATCH v4 00/33] DPDK Trace support

Thomas Monjalon thomas at monjalon.net
Fri Apr 10 17:12:44 CEST 2020


10/04/2020 15:29, Jerin Jacob:
> On Fri, Apr 10, 2020 at 6:45 PM David Marchand
> <david.marchand at redhat.com> wrote:
> > On Thu, Apr 9, 2020 at 8:27 PM Jerin Jacob <jerinjacobk at gmail.com> wrote:
> > > # In summary:
> > > ~~~~~~~~~~~~~
> > > # In the existing code:
> > > The trace will be emitted when
> > >  a) When the trace is enabled
> > >  AND
> > > b) trace level than the global level.
> > >
> > > # in new suggestion
> > > The trace will be emitted when
> > >  a) When it is enabled
> > >
> > > And the EAL argument will be --trace=regex/globbing, This EAL argument
> > > will call rte_trace_regexp() and enable the selected tracepoints.
> > >
> > > The downside will be it will not be similar to log API. I am fine with
> > > either way.
> >
> > The level notion in the traces api is artificial.
> > I prefer a simple api where tracepoints state is controlled via a
> > single criteria: with the new suggestion that would be names.
> > So +1.
> 
> I thought it may be helpful to replace log and I decided to pick the
> level in the trace.
> 
> Looks like the consensus is to remove "level" from Trace.

I miss the plan to rework logs on top of trace.
How could it be done?




More information about the dev mailing list