[dpdk-dev] [PATCH] devtools: ignore PREFER_FALLTHROUGH
Thomas Monjalon
thomas at monjalon.net
Wed Aug 5 11:12:12 CEST 2020
04/08/2020 09:38, Adrian Moreno:
> The PREFER_FALLTHROUGH check warns if a passthrough comment is found
> because, in the kernel, the special macro "fallthrough" is prefered.
>
> Since that keyword is not defined in DPDK, ignore the warning.
We could ask why not defining a similar keyword?
>
> Ignoring this check does not affect the MISSING_BREAK check that will
> warn if a switch case/default is not preceded by break or a fallthrough
> comment.
>
> Signed-off-by: Adrian Moreno <amorenoz at redhat.com>
> ---
> devtools/checkpatches.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
> index acf921ae0..4283ca82b 100755
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> @@ -33,7 +33,7 @@ VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\
> PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\
> SPLIT_STRING,LONG_LINE_STRING,C99_COMMENT_TOLERANCE,\
> LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
> -NEW_TYPEDEFS,COMPARISON_TO_NULL"
> +NEW_TYPEDEFS,COMPARISON_TO_NULL,PREFER_FALLTHROUGH"
I would add this option between PREFER_KERNEL_TYPES and BIT_MACRO
to maintain a bit of logic ordering.
More information about the dev
mailing list