[dpdk-dev] [PATCH v2 3/4] net/bnxt: fix cleanup and check for ulp context alloc

Thomas Monjalon thomas at monjalon.net
Wed Aug 5 22:27:11 CEST 2020


31/07/2020 19:23, Ajit Khaparde:
> From: Somnath Kotur <somnath.kotur at broadcom.com>
> 
> Set ulp_ctx explicitly to NULL in ulp_ctx_deinit() so that representor
> init is aborted if parent ulp context is not initialized.
> Also check for the same before creation of port default rules.
> Additional checks in VF rep dev ops for proper parent dev initialization

Looks like it should be separate patche.

I don't know what is "ulp", but if it an acronym,
it should be in capital letters.

> Fixes: 322bd6e70272 ("net/bnxt: add port representor infrastructure")
> Fixes: 313ac35ac701 ("net/bnxt: support ULP session manager init")

Not clear it is a fix.
Looks like adding more checks.

> Reviewed-by: Venkat Duvvuru <venkatkumar.duvvuru at broadcom.com>

Reviewed-by should be below Signed-off-by.

> Signed-off-by: Somnath Kotur <somnath.kotur at broadcom.com>





More information about the dev mailing list