[dpdk-dev] [PATCH 4/4] test/stack: remove atomics operations

Eads, Gage gage.eads at intel.com
Tue Aug 11 22:13:50 CEST 2020



> -----Original Message-----
> From: Steven Lariau <steven.lariau at arm.com>
> Sent: Wednesday, August 5, 2020 10:57 AM
> To: Eads, Gage <gage.eads at intel.com>; Olivier Matz
> <olivier.matz at 6wind.com>
> Cc: dev at dpdk.org; honnappa.nagarahalli at arm.com;
> dharmik.thakkar at arm.com; nd at arm.com; Steven Lariau
> <steven.lariau at arm.com>
> Subject: [PATCH 4/4] test/stack: remove atomics operations
> 
> Remove the part that checks if there is enough room in the stack, it's
> always true as long as size of stack >= MAX_BULK*rte_lcore_count().
> This check used an atomic cmpset, and read / write to a shared size
> variable. These operations result in some form of synchronization
> that might get in the way of the actual stack testing.
> 
> Signed-off-by: Steven Lariau <steven.lariau at arm.com>
> Reviewed-by: Dharmik Thakkar <dharmik.thakkar at arm.com>
> Reviewed-by: Phil Yang <phil.yang at arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang at arm.com>

Nice simplification, and thanks for the good contributions to these tests.

Acked-by: Gage Eads <gage.eads at intel.com


More information about the dev mailing list