[dpdk-dev] [EXT] Re: [PATCH v3 2/2] net/octeontx2: add rss hash level support

[Kiran Kumar Kokkilagadda]

> -----Original Message-----
> From: Jerin Jacob <jerinjacobk at gmail.com>
> Sent: Tuesday, August 18, 2020 3:34 PM
> To: Kiran Kumar Kokkilagadda <kirankumark at marvell.com>
> Cc: Jerin Jacob Kollanukkaran <jerinj at marvell.com>; Nithin Kumar Dabilpuram
> <ndabilpuram at marvell.com>; dpdk-dev <dev at dpdk.org>; Thomas Monjalon
> <thomas at monjalon.net>; Ferruh Yigit <ferruh.yigit at intel.com>; Andrew
> Rybchenko <arybchenko at solarflare.com>; Ori Kam <orika at mellanox.com>;
> Ziyang Xuan <xuanziyang2 at huawei.com>; Xiaoyun Wang
> <cloud.wangxiaoyun at huawei.com>; Guoyang Zhou
> <zhouguoyang at huawei.com>; Rosen Xu <rosen.xu at intel.com>; Beilei Xing
> <beilei.xing at intel.com>; jia.guo at intel.com; Rasesh Mody
> <rmody at marvell.com>; Shahed Shaikh <shshaikh at marvell.com>; Qiming Yang
> <qiming.yang at intel.com>; Qi Zhang <qi.z.zhang at intel.com>; Wiles, Keith
> <keith.wiles at intel.com>; Hemant Agrawal <hemant.agrawal at nxp.com>;
> Sachin Saxena <sachin.saxena at nxp.com>; Zhao1, Wei <wei.zhao1 at intel.com>;
> John Daley <johndale at cisco.com>; Hyong Youb Kim <hyonkim at cisco.com>;
> Chas Williams <chas3 at att.com>; Matan Azrad <matan at mellanox.com>;
> Shahaf Shuler <shahafs at mellanox.com>; Slava Ovsiienko
> <viacheslavo at mellanox.com>; Rahul Lakkireddy
> <rahul.lakkireddy at chelsio.com>; Gaetan Rivet <grive at u256.net>; Liron Himi
> <lironh at marvell.com>; Jingjing Wu <jingjing.wu at intel.com>; Wei Hu (Xavier
> <xavier.huwei at huawei.com>; Min Hu (Connor <humin29 at huawei.com>; Yisen
> Zhuang <yisen.zhuang at huawei.com>; Ajit Khaparde
> <ajit.khaparde at broadcom.com>; Somnath Kotur
> <somnath.kotur at broadcom.com>; Jasvinder Singh
> <jasvinder.singh at intel.com>; Cristian Dumitrescu
> <cristian.dumitrescu at intel.com>
> Subject: [EXT] Re: [dpdk-dev] [PATCH v3 2/2] net/octeontx2: add rss hash level
> support
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Tue, Aug 18, 2020 at 12:52 PM <kirankumark at marvell.com> wrote:
> >
> > From: Kiran Kumar K <kirankumark at marvell.com>
> >
> > Add support to choose rss hash level from ethdev rss config.
> >
> > Signed-off-by: Kiran Kumar K <kirankumark at marvell.com>
> > ---
> >  drivers/net/octeontx2/otx2_ethdev.h | 4 +++-
> >  drivers/net/octeontx2/otx2_rss.c    | 9 +++++++--
> >  2 files changed, 10 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/octeontx2/otx2_ethdev.h
> > b/drivers/net/octeontx2/otx2_ethdev.h
> > index e9efe52bb..953445ecb 100644
> > --- a/drivers/net/octeontx2/otx2_ethdev.h
> > +++ b/drivers/net/octeontx2/otx2_ethdev.h
> > @@ -119,7 +119,9 @@
> >  #define NIX_RSS_OFFLOAD                (ETH_RSS_PORT | ETH_RSS_IP |
> ETH_RSS_UDP |\
> >                                  ETH_RSS_TCP | ETH_RSS_SCTP | \
> >                                  ETH_RSS_TUNNEL | ETH_RSS_L2_PAYLOAD | \
> > -                                NIX_RSS_L3_L4_SRC_DST)
> > +                                NIX_RSS_L3_L4_SRC_DST | ETH_RSS_LEVEL_INNER | \
> > +                                ETH_RSS_LEVEL_OUTER | \
> > +                                ETH_RSS_LEVEL_INNER_OUTER)
> 
> Since it is value 1 and 2, for bitmask purpose, shouldn't be
> ETH_RSS_LEVEL_MASK  instead of ETH_RSS_LEVEL_OUTER |
> ETH_RSS_LEVEL_INNER_OUTER


Will update in V4.