[dpdk-dev] [PATCH] eal: change debug diagnostic message from udev handler
Jeff Guo
jia.guo at intel.com
Wed Aug 19 05:40:16 CEST 2020
hi, stephen
Agree, it is make sense that the ignore event will sometimes involve the
information which should not be ignore.
On 8/15/2020 1:45 AM, Stephen Hemminger wrote:
> The debug message was poorly worded and did not include the
> part that would be useful. I.e it never said what was being ignored.
> Change it to print the message so that if udev changes format or
> other subsystems need to be added then the necessary information
> will be in the debug log.
>
> Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process")
> Cc: jia.guo at intel.com
Should this cc line be removed? After that, please and thanks.
Acked-by: Jeff Guo <jia.guo at intel.com>.
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> ---
> lib/librte_eal/linux/eal_dev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lib/librte_eal/linux/eal_dev.c b/lib/librte_eal/linux/eal_dev.c
> index 83c9cd660754..83b6068264cb 100644
> --- a/lib/librte_eal/linux/eal_dev.c
> +++ b/lib/librte_eal/linux/eal_dev.c
> @@ -234,8 +234,7 @@ dev_uev_handler(__rte_unused void *param)
>
> ret = dev_uev_parse(buf, &uevent, EAL_UEV_MSG_LEN);
> if (ret < 0) {
> - RTE_LOG(DEBUG, EAL, "It is not an valid event "
> - "that need to be handle.\n");
> + RTE_LOG(DEBUG, EAL, "Ignoring uevent '%s'\n", buf);
> return;
> }
>
More information about the dev
mailing list