[dpdk-dev] [PATCH] cmdline: avoid name clash with Windows system types

[Ranjit Menon]

On 8/21/2020 11:48 AM, Dmitry Kozlyuk wrote:
> cmdline_numtype member names clash with Windows system identifiers.
> Add CMDLINE_ prefix to cmdline constants to avoid this and possible
> future conflicts.
>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk at gmail.com>
> Suggested-by: Ranjit Menon <ranjit.menon at intel.com>
> ---
>
> This patch made some lines overlong. When breaking them, indentation
> style is kept consistent with nearby code; it's weird in some places.
>
>   app/test-cmdline/commands.c                   |   2 +-
>   app/test-pmd/bpf_cmd.c                        |  10 +-
>   app/test-pmd/cmdline.c                        | 715 ++++++++++--------
>   app/test-pmd/cmdline_flow.c                   |   2 +-
>   app/test-pmd/cmdline_mtr.c                    |  92 ++-
>   app/test-pmd/cmdline_tm.c                     | 177 ++---
>   app/test/test_cmdline_num.c                   |  48 +-
>   examples/ethtool/ethtool-app/ethapp.c         |  19 +-
>   examples/ipsec-secgw/parser.c                 |   2 +-
>   examples/qos_sched/cmdline.c                  |  46 +-
>   .../guest_cli/vm_power_cli_guest.c            |   2 +-
>   examples/vm_power_manager/vm_power_cli.c      |   8 +-
>   lib/librte_cmdline/cmdline_parse_num.c        |  65 +-
>   lib/librte_cmdline/cmdline_parse_num.h        |  16 +-
>   14 files changed, 627 insertions(+), 577 deletions(-)
>
> <Snip>

Thanks for doing this, Dmitry!

Acked-by: Ranjit Menon <ranjit.menon at intel.com>