[dpdk-dev] [PATCH v2 1/6] net/iavf: fix scattered Rx enabling

[Xing, Beilei]

> -----Original Message-----
> From: Yang, SteveX <stevex.yang at intel.com>
> Sent: Thursday, August 27, 2020 9:14 AM
> To: dev at dpdk.org
> Cc: Yang, Qiming <qiming.yang at intel.com>; Wu, Jingjing
> <jingjing.wu at intel.com>; Xing, Beilei <beilei.xing at intel.com>; Yang, SteveX
> <stevex.yang at intel.com>
> Subject: [PATCH v2 1/6] net/iavf: fix scattered Rx enabling
> 
> No need to add additional vlan tag size for max packet size, since for i40e, the

Seems my comment in v1 patch is not addressed.

> queue's Rx Max Frame Size (rxq->max_pkt_len) already includes the vlan
> header size.
> 
> Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
> 
> Signed-off-by: SteveX Yang <stevex.yang at intel.com>
> ---
>  drivers/net/iavf/iavf_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
> index c3aa4cd72..f9dd5710c 100644
> --- a/drivers/net/iavf/iavf_ethdev.c
> +++ b/drivers/net/iavf/iavf_ethdev.c
> @@ -253,7 +253,7 @@ iavf_init_rxq(struct rte_eth_dev *dev, struct
> iavf_rx_queue *rxq)
> 
>  	rxq->max_pkt_len = max_pkt_len;
>  	if ((dev_data->dev_conf.rxmode.offloads &
> DEV_RX_OFFLOAD_SCATTER) ||
> -	    (rxq->max_pkt_len + 2 * IAVF_VLAN_TAG_SIZE) > buf_size) {
> +	    rxq->max_pkt_len > buf_size) {
>  		dev_data->scattered_rx = 1;
>  	}
>  	IAVF_PCI_REG_WRITE(rxq->qrx_tail, rxq->nb_rx_desc - 1);
> --
> 2.17.1