[dpdk-dev] [PATCH 4/7] ethdev: mark internal functions

[Andrew Rybchenko]

On 8/24/20 12:40 PM, Ferruh Yigit wrote:
> Some ethdev functions are for drivers only, not for applications.
> 
> Since we have '__rte_internal' tag available now, marking internal
> functions with it and moving functions to INTERNAL section in linker
> script.
> This is also good for documenting the internal functions.
> 
> Some internal APIs seems marked as experimental, but it doesn't make
> sense to have internals APIs as experimental, updating their tag and
> doxygen comments.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>

Acked-by: Andrew Rybchenko <arybchenko at solarflare.com>

with a nit below

[snip]

> diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
> index 2ce186610b..ce2e0ec0e4 100644
> --- a/lib/librte_ethdev/rte_ethdev.h
> +++ b/lib/librte_ethdev/rte_ethdev.h
> @@ -1723,8 +1723,7 @@ rte_eth_find_next_of(uint16_t port_id_start,
>   */
>  __rte_experimental
>  uint16_t
> -rte_eth_find_next_sibling(uint16_t port_id_start,
> -		uint16_t ref_port_id);
> +rte_eth_find_next_sibling(uint16_t port_id_start, uint16_t ref_port_id);

Looks unrelated

[snip]