[dpdk-dev] [PATCH] ethdev: add rx offload to drop error packets

[Ferruh Yigit]

On 8/31/2020 8:53 AM, Nipun Gupta wrote:
> This change adds a RX offload capability where hardware can drop the
> packets in case there is an error in the packet such as L3 checksum
> error or L4 checksum.
> 
> Signed-off-by: Nipun Gupta <nipun.gupta at nxp.com>
> Signed-off-by: Rohit Raj <rohit.raj at nxp.com>
> ---
>  lib/librte_ethdev/rte_ethdev.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
> index a49242bcd..bb9df2fb9 100644
> --- a/lib/librte_ethdev/rte_ethdev.h
> +++ b/lib/librte_ethdev/rte_ethdev.h
> @@ -1120,6 +1120,7 @@ struct rte_eth_conf {
>  #define DEV_RX_OFFLOAD_SCTP_CKSUM	0x00020000
>  #define DEV_RX_OFFLOAD_OUTER_UDP_CKSUM  0x00040000
>  #define DEV_RX_OFFLOAD_RSS_HASH		0x00080000
> +#define DEV_RX_OFFLOAD_ERR_PKT_DROP	0x00100000
>  
>  #define DEV_RX_OFFLOAD_CHECKSUM (DEV_RX_OFFLOAD_IPV4_CKSUM | \
>  				 DEV_RX_OFFLOAD_UDP_CKSUM | \
> 


Hi Nipun,

You adding a new offload type for network devices, it should have some more
description and relevant PMD/testpmd updates too.

But before that, is dropping faulty packets an offload or a config option for
the NIC? Or is this common for all NICs to have in ethdev?