[dpdk-dev] [PATCH] net/ixgbe: fix coverity issue

Guinan Sun guinanx.sun at intel.com
Mon Feb 10 05:15:25 CET 2020


This patch fixes (Logically dead code) coverity issue.

Coverity issue: 353613
Fixes: 3c4270187518 ("net/ixgbe: support VF MAC address add/remove")

Signed-off-by: Guinan Sun <guinanx.sun at intel.com>
---
 drivers/net/ixgbe/ixgbe_pf.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c
index 493f0f2b9..afae21f81 100644
--- a/drivers/net/ixgbe/ixgbe_pf.c
+++ b/drivers/net/ixgbe/ixgbe_pf.c
@@ -772,9 +772,6 @@ ixgbe_set_vf_macvlan_msg(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf)
 		    IXGBE_VT_MSGINFO_SHIFT;
 
 	if (index) {
-		if (new_mac == NULL)
-			return -1;
-
 		if (!rte_is_valid_assigned_ether_addr(
 			(struct rte_ether_addr *)new_mac)) {
 			PMD_DRV_LOG(ERR, "set invalid mac vf:%d\n", vf);
-- 
2.17.1



More information about the dev mailing list