[dpdk-dev] [PATCH v5 1/8] eal/x86: introduce AVX 512-bit type
Thomas Monjalon
thomas at monjalon.net
Mon Jul 13 12:25:39 CEST 2020
13/07/2020 12:23, Medvedkin, Vladimir:
> Hi Thomas,
>
> On 10/07/2020 22:49, Thomas Monjalon wrote:
> > Please Cc those who participated in the review previously.
> > Adding Ray, Jerin, David.
> >
> > 10/07/2020 16:46, Vladimir Medvedkin:
> >> + __m512i z;
> >> + ymm_t y[RTE_X86_ZMM_SIZE / sizeof(ymm_t)];
> >> + xmm_t x[RTE_X86_ZMM_SIZE / sizeof(xmm_t)];
> >> + uint8_t u8[RTE_X86_ZMM_SIZE / sizeof(uint8_t)];
> >> + uint16_t u16[RTE_X86_ZMM_SIZE / sizeof(uint16_t)];
> >> + uint32_t u32[RTE_X86_ZMM_SIZE / sizeof(uint32_t)];
> >> + uint64_t u64[RTE_X86_ZMM_SIZE / sizeof(uint64_t)];
> >> + double pd[RTE_X86_ZMM_SIZE / sizeof(double)];
> >> +} __rte_aligned(RTE_X86_ZMM_SIZE) __rte_x86_zmm_t;
> >> +
> >> +#endif /* __AVX512F__ */
> >
> > You were supposed to undef the macros above.
>
> It was intentional. It could be used later by other libs, like XMM_SIZE:
> git grep -lw XMM_SIZE
> lib/librte_acl/acl_gen.c
> lib/librte_acl/acl_run.h
> lib/librte_acl/rte_acl.h
> lib/librte_eal/arm/include/rte_vect.h
> lib/librte_eal/ppc/include/rte_vect.h
> lib/librte_eal/x86/include/rte_vect.h
> lib/librte_hash/rte_thash.h
OK. Was it agreed with David to NOT undef?
I may have missed this part.
More information about the dev
mailing list