[dpdk-dev] [PATCH v1] net/virtio-user: fix uninitialized variable

[Adrian Moreno]

On 7/14/20 1:03 PM, Chenbo Xia wrote:
> This patch fixes an issue that uninitialized has_reply_ack
> is used for setting message flags.
> 
> Coverity issue: 360834
> Fixes: c60208dd6384 ("net/virtio-user: support reply-ack")
> 
> Signed-off-by: Chenbo Xia <chenbo.xia at intel.com>
> ---
>  drivers/net/virtio/virtio_user/vhost_user.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/virtio/virtio_user/vhost_user.c b/drivers/net/virtio/virtio_user/vhost_user.c
> index 631d0e353..ad48bafd4 100644
> --- a/drivers/net/virtio/virtio_user/vhost_user.c
> +++ b/drivers/net/virtio/virtio_user/vhost_user.c
> @@ -254,7 +254,7 @@ vhost_user_sock(struct virtio_user_dev *dev,
>  	struct vhost_user_msg msg;
>  	struct vhost_vring_file *file = 0;
>  	int need_reply = 0;
> -	int has_reply_ack;
> +	int has_reply_ack = 0;
>  	int fds[VHOST_MEMORY_MAX_NREGIONS];
>  	int fd_num = 0;
>  	int len;
> 

Acked-by: Adrián Moreno <amorenoz at redhat.com>
-- 
Adrián Moreno