[dpdk-dev] [PATCH v2] app/testpmd: fix txonly mode timestamp intitialization

[Phil Yang]

> -----Original Message-----
> From: Viacheslav Ovsiienko <viacheslavo at mellanox.com>
> Sent: Wednesday, July 29, 2020 8:30 PM
> To: dev at dpdk.org
> Cc: matan at mellanox.com; rasland at mellanox.com; thomas at monjalon.net;
> ferruh.yigit at intel.com; Phil Yang <Phil.Yang at arm.com>
> Subject: [PATCH v2] app/testpmd: fix txonly mode timestamp intitialization
> 
> The testpmd application forwards data in multiple threads.
> In the txonly mode the Tx timestamps must be initialized
> on per thread basis to provide phase shift for the packet
> burst being sent. This per thread initialization was performed
> on zero value of the variable in thread local storage and
> happened only once after testpmd forwarding start. Executing
> "start" and "stop" commands did not cause thread local variables
> zeroing and wrong timestamp values were used.
> 
> Fixes: 4940344dab1d ("app/testpmd: add Tx scheduling command")
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo at mellanox.com>

It looks good to me. 

Reviewed-by: Phil Yang <phil.yang at arm.com>

Thanks,
Phil

<...>