[dpdk-dev] [PATCH v2] net/axgbe: add support for Scattered Rx

[Ferruh Yigit]

On 3/4/2020 1:44 PM, ssebasti at amd.com wrote:
> From: Selwin Sebastian <selwin.sebastian at amd.com>
> 
> Enable scattered rx support and add jumbo packet receive capability
> 
> Signed-off-by: Selwin Sebastian <selwin.sebastian at amd.com>

<...>

> @@ -249,6 +249,10 @@ axgbe_dev_start(struct rte_eth_dev *dev)
>  {
>  	struct axgbe_port *pdata = dev->data->dev_private;
>  	int ret;
> +	struct rte_eth_dev_data *dev_data = dev->data;
> +	uint16_t max_pkt_len = dev_data->dev_conf.rxmode.max_rx_pkt_len;
> +
> +	dev->dev_ops = &axgbe_eth_dev_ops;

Is this assignment required, isn't it already set in init (eth_axgbe_dev_init)?

<...>

> diff --git a/drivers/net/axgbe/axgbe_rxtx.c b/drivers/net/axgbe/axgbe_rxtx.c
> index 96055c25b..57e2bbb34 100644
> --- a/drivers/net/axgbe/axgbe_rxtx.c
> +++ b/drivers/net/axgbe/axgbe_rxtx.c
> @@ -307,6 +307,152 @@ axgbe_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
>  	return nb_rx;
>  }
>  
> +

monor nit, there is additional empty line here.