[dpdk-dev] [PATCH v2 3/7] net/ice: initiate to acquire the DCF capability

[Wang, Haiyue]

> -----Original Message-----
> From: Ye, Xiaolong <xiaolong.ye at intel.com>
> Sent: Friday, March 13, 2020 14:04
> To: Wang, Haiyue <haiyue.wang at intel.com>
> Cc: dev at dpdk.org; Zhang, Qi Z <qi.z.zhang at intel.com>; Yang, Qiming <qiming.yang at intel.com>; Xing,
> Beilei <beilei.xing at intel.com>; Zhao1, Wei <wei.zhao1 at intel.com>
> Subject: Re: [PATCH v2 3/7] net/ice: initiate to acquire the DCF capability
> 
> On 03/10, Haiyue Wang wrote:
> 
> >
> >+static int
> >+ice_dcf_mode_disable(struct ice_dcf_hw *hw)
> >+{
> >+	int err;
> >+
> >+	err = ice_dcf_send_cmd_req_no_irq(hw, VIRTCHNL_OP_DCF_DISABLE,
> >+					  NULL, 0);
> >+	if (err) {
> >+		PMD_DRV_LOG(ERR, "Fail to send msg OP_DCF_DISABLE");
> >+		return err;
> >+	}
> >+
> >+	err = ice_dcf_recv_cmd_rsp_no_irq(hw, VIRTCHNL_OP_DCF_DISABLE,
> >+					  (uint8_t *)hw->arq_buf,
> 
> Unnecessary cast.

will be fixed in next patch.

> 
> >+					  ICE_DCF_AQ_BUF_SZ, NULL);
> >+	if (err) {
> >+		PMD_DRV_LOG(ERR,
> >+			    "Fail to get response of OP_DCF_DISABLE %d",
> >+			    err);
> >+		return -1;
> >+	}
> >+
> >+	return 0;
> >+}