[dpdk-dev] [PATCH RFC v1 4/7] net/ena: relax barrier for completion queue update
Gavin Hu
gavin.hu at arm.com
Fri Mar 13 10:18:32 CET 2020
To gaurantee the update observed by NIC HW, a cio barrier is sufficient,
an io barrier, which translates to dsb on aarch64, is overkill.
Suggested-by: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
Signed-off-by: Gavin Hu <gavin.hu at arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
---
drivers/net/ena/base/ena_eth_com.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ena/base/ena_eth_com.h b/drivers/net/ena/base/ena_eth_com.h
index e56c33a64..edfa98b72 100644
--- a/drivers/net/ena/base/ena_eth_com.h
+++ b/drivers/net/ena/base/ena_eth_com.h
@@ -180,7 +180,9 @@ static inline int ena_com_update_dev_comp_head(struct ena_com_io_cq *io_cq)
if (unlikely(need_update)) {
ena_trc_dbg("Write completion queue doorbell for queue %d: head: %d\n",
io_cq->qid, head);
- ENA_REG_WRITE32(io_cq->bus, head, io_cq->cq_head_db_reg);
+ rte_cio_wmb();
+ ENA_REG_WRITE32_RELAXED(io_cq->bus, head,
+ io_cq->cq_head_db_reg);
io_cq->last_head_update = head;
}
}
--
2.17.1
More information about the dev
mailing list