[dpdk-dev] [PATCH v2] net/i40e: fix out of bounds read issue

[Ye Xiaolong]

Hi, Qiming

On 05/08, Yang, Qiming wrote:
>Nacked by: Qiming Yang <Qiming.yang at intel.com>

Could you post the reason why you nack this patch?

Thanks,
Xiaolong

>
>> -----Original Message-----
>> From: dev <dev-bounces at dpdk.org> On Behalf Of Chenxu Di
>> Sent: Thursday, May 7, 2020 17:50
>> To: dev at dpdk.org
>> Cc: Di, ChenxuX <chenxux.di at intel.com>
>> Subject: [dpdk-dev] [PATCH v2] net/i40e: fix out of bounds read issue
>> 
>> This patch fixes (out-of-bounds read) coverity issue.
>> 
>> Coverity issue: 357699
>> Coverity issue: 357694
>> Fixes: feaae285b342 ("net/i40e: support hash configuration in RSS flow")
>> 
>> Signed-off-by: Chenxu Di <chenxux.di at intel.com>
>> ---
>>  drivers/net/i40e/i40e_ethdev.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
>> 
>> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
>> index 749d85f54..c2d5c6835 100644
>> --- a/drivers/net/i40e/i40e_ethdev.c
>> +++ b/drivers/net/i40e/i40e_ethdev.c
>> @@ -13179,6 +13179,9 @@ i40e_rss_config_hash_function(struct i40e_pf
>> *pf,
>>  				break;
>>  		}
>> 
>> +		if (i == UINT64_BIT)
>> +			return 0;
>> +
>
>
>
>>  		for (j = I40E_FILTER_PCTYPE_INVALID + 1;
>>  		     j < I40E_FILTER_PCTYPE_MAX; j++) {
>>  			if (pf->adapter->pctypes_tbl[i] & (1ULL << j)) @@ -
>> 13311,6 +13314,9 @@ i40e_rss_clear_hash_function(struct i40e_pf *pf,
>>  				break;
>>  		}
>> 
>> +		if (i == UINT64_BIT)
>> +			return 0;
>> +
>>  		for (j = I40E_FILTER_PCTYPE_INVALID + 1;
>>  		     j < I40E_FILTER_PCTYPE_MAX; j++) {
>>  			if (pf->adapter->pctypes_tbl[i] & (1ULL << j))
>> --
>> 2.17.1
>