[dpdk-dev] [PATCH v2 1/9] cryptodev: add feature flag for non-byte aligned data

[De Lara Guarch, Pablo]

Hi Akhil,

> -----Original Message-----
> From: Akhil Goyal <akhil.goyal at nxp.com>
> Sent: Sunday, May 10, 2020 12:12 AM
> To: dev at dpdk.org
> Cc: Ruifeng.Wang at arm.com; Doherty, Declan <declan.doherty at intel.com>;
> asomalap at amd.com; anoobj at marvell.com; Zhang, Roy Fan
> <roy.fan.zhang at intel.com>; Trahe, Fiona <fiona.trahe at intel.com>;
> rnagadheeraj at marvell.com; adwivedi at marvell.com; G.Singh at nxp.com;
> hemant.agrawal at nxp.com; jianjay.zhou at huawei.com; De Lara Guarch, Pablo
> <pablo.de.lara.guarch at intel.com>; Dybkowski, AdamX
> <adamx.dybkowski at intel.com>; apeksha.gupta at nxp.com; Akhil Goyal
> <akhil.goyal at nxp.com>
> Subject: [PATCH v2 1/9] cryptodev: add feature flag for non-byte aligned data
> 
> Some wireless algos like SNOW, ZUC may support input data in bits which are
> not byte aligned. However, not all PMDs can support this requirement. Hence
> added a new feature flag RTE_CRYPTODEV_FF_NON_BYTE_ALIGNED_DATA
> to identify which all PMDs can support non-byte aligned data.
> 
> Signed-off-by: Akhil Goyal <akhil.goyal at nxp.com>
> Acked-by: Fiona Trahe <fiona.trahe at intel.com>

On these PMDs, some of these algorithms do not support non byte aligned data.
For instance, for ZUC, the cipher algorithm doesn't support length in bits,
but the authentication algorithm does.
All test pass because in the tests we are doing encryption in bytes and then we mask off
the bits not used.
Wonder if we need two different flags for this, one for cipher and another one for authentication.
Maybe again this is not enough, since we should have a flag per algorithm... and starting with this flag is a step forward.
What do you think?

Thanks for looking into this!
Pablo