[dpdk-dev] [PATCH] bus/fslmc: drop inline from non-static functions

[David Marchand]

On Wed, May 20, 2020 at 12:22 PM Ferruh Yigit <ferruh.yigit at intel.com> wrote:
>
> There is no point in having non-static (and non-extern) inline
> functions.
>
> Also this breaks the build for the ICC [1] because of the 'internal'
> symbol check.
>
> When function is 'inline' ICC is ignoring 'section' attribute and not
> putting function to 'internal' section which breaks 'check-symbols.sh'
> script with below error.
>
> [1]
> qbman_swp_dqrr_next is not flagged as internal
> but is listed in version map
> Please add __rte_internal to the definition of qbman_swp_dqrr_next
> qbman_swp_enqueue_multiple is not flagged as internal
> but is listed in version map
> Please add __rte_internal to the definition of qbman_swp_enqueue_multiple
> qbman_swp_enqueue_multiple_desc is not flagged as internal
> but is listed in version map
> Please add __rte_internal to the definition of qbman_swp_enqueue_multiple_desc
> qbman_swp_enqueue_multiple_fd is not flagged as internal
> but is listed in version map
> Please add __rte_internal to the definition of qbman_swp_enqueue_multiple_fd
> qbman_swp_pull is not flagged as internal
> but is listed in version map
> Please add __rte_internal to the definition of qbman_swp_pull
> qbman_swp_release is not flagged as internal
> but is listed in version map
> Please add __rte_internal to the definition of qbman_swp_release
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>

Acked-by: Hemant Agrawal <hemant.agrawal at nxp.com>


Applied, thanks Ferruh.

-- 
David Marchand