[dpdk-dev] [PATCH v14 05/23] event/dlb: add inline functions

[David Marchand]

On Sun, Nov 1, 2020 at 7:07 PM McDaniel, Timothy
<timothy.mcdaniel at intel.com> wrote:
> > Availability of the MOVDIR64B instruction is indicated by the presence
> > of the CPUID feature flag MOVDIR64B (bit 28 of the ECX register in
> > leaf 07H, see “CPUID—CPU Identification” in the Intel® 64 and IA-32
> > Architectures Software Developer’s Manual, Volume 2A).
> >
> > I understand that calling this code must be under a check for
> > RTE_CPUFLAG_MOVDIR64B.
> > Which I can't find in this patchset.
>
> Fair enough question. We currently do not check for availability of MOVDIR64B since
> every Intel part that includes DLB or DLB2 is guaranteed to have the MOVDIR64B
> instruction.

A check at probe time would not hurt, but if you are sure of it, ok.


-- 
David Marchand