[dpdk-dev] [PATCH 1/8] regex/octeontx2: fix unnecessary name override

[David Marchand]

On Tue, Nov 3, 2020 at 10:06 AM Thomas Monjalon <thomas at monjalon.net> wrote:
>
> 03/11/2020 09:19, David Marchand:
> > On Tue, Nov 3, 2020 at 1:30 AM Thomas Monjalon <thomas at monjalon.net> wrote:
> > > > > -name = 'octeontx2_regex'
> > >
> > > But it is not the same?
> > >
> > > The name will default to "octeontx2", which is fine.
> > > But the fmt_name should not take this default.
> > > I believe fmt_name should be "octeontx2_regex" as I did in my patch.
> >
> > fmt_name is only for maintaining config compat.
> > This driver is new to 20.11.
> > We can drop fmt_name too.
>
> If we don't set fmt_name, it defaults to "name", "octeontx2" here.
> What is the consequence in compat definitions?

$ git reset --hard origin/main
HEAD is now at 30cf171352 app/regex: add job context
$ ninja-build -C build >/dev/null 2>&1 && ls -rt
build/drivers/*regex*octeo*.so.21.0 |tail -1; grep OCTEONTX2
build/rte_build_config.h  |grep REG
build/drivers/librte_regex_octeontx2_regex.so.21.0
#define RTE_LIBRTE_OCTEONTX2_REGEX_PMD 1
#define RTE_REGEX_OCTEONTX2_REGEX 1

$ git reset --hard origin/main
HEAD is now at 30cf171352 app/regex: add job context
$ git pw patch apply 81961
Applying: regex/octeontx2: fix driver name
$ ninja-build -C build >/dev/null 2>&1 && ls -rt
build/drivers/*regex*octeo*.so.21.0 |tail -1; grep OCTEONTX2
build/rte_build_config.h  |grep REG
build/drivers/librte_regex_octeontx2.so.21.0
#define RTE_LIBRTE_OCTEONTX2_REGEX_PMD 1
#define RTE_REGEX_OCTEONTX2 1

$ git reset --hard origin/main
HEAD is now at 30cf171352 app/regex: add job context
$ git pw patch apply --no-deps 83425
Applying: regex/octeontx2: fix unnecessary name override
$ ninja-build -C build >/dev/null 2>&1 && ls -rt
build/drivers/*regex*octeo*.so.21.0 |tail -1; grep OCTEONTX2
build/rte_build_config.h  |grep REG
build/drivers/librte_regex_octeontx2.so.21.0
#define RTE_REGEX_OCTEONTX2 1

-- 
David Marchand