[dpdk-dev] [v21.02 v3 05/10] net/pcap: remove local variable shadowing outer one
Ferruh Yigit
ferruh.yigit at intel.com
Thu Nov 19 12:58:55 CET 2020
'ret' is already defined in the function scope, removing the 'ret' in
the block scope.
Fixes: c9507cd0cada ("net/pcap: support physical interface MAC address")
Cc: stable at dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
---
v3:
* Eliminated block scope 'ret' variable usage completely.
---
drivers/net/pcap/rte_eth_pcap.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c
index 4930d7d382..90929478eb 100644
--- a/drivers/net/pcap/rte_eth_pcap.c
+++ b/drivers/net/pcap/rte_eth_pcap.c
@@ -1324,9 +1324,8 @@ eth_from_pcaps(struct rte_vdev_device *vdev,
/* phy_mac arg is applied only only if "iface" devarg is provided */
if (rx_queues->phy_mac) {
- int ret = eth_pcap_update_mac(rx_queues->queue[0].name,
- eth_dev, vdev->device.numa_node);
- if (ret == 0)
+ if(eth_pcap_update_mac(rx_queues->queue[0].name,
+ eth_dev, vdev->device.numa_node) == 0)
internals->phy_mac = 1;
}
}
--
2.26.2
More information about the dev
mailing list