[dpdk-dev] [PATCH v3 14/37] devtools: remove use of make in scripts

Thomas Monjalon thomas at monjalon.net
Sun Sep 6 12:15:32 CEST 2020


On Thu Sep 3, 2020 at 6:26 PM CEST, Ciara Power wrote:
> --- a/devtools/build-tags.sh
> +++ b/devtools/build-tags.sh
[...]
> + echo "Examples of valid configs are: "
> + echo "x86_64-native-linux-gcc, arm64-armv8a-linux-gcc,
> ppc_64-power8-linux-gcc"

Only arch and OS are used in this script.
I would give these simpler examples:
	x86_64-bsd, arm64-linux, ppc_64-linux

[...]
> --- a/devtools/check-includes.sh
> +++ b/devtools/check-includes.sh
> @@ -17,8 +17,7 @@
> #
> # SUMMARY=1 is the same as -s.
> #
> -# CC, CPPFLAGS, CFLAGS, EXTRA_CPPFLAGS, EXTRA_CFLAGS, CXX, CXXFLAGS and
> -# EXTRA_CXXFLAGS are taken into account.
> +# CC, CPPFLAGS, CFLAGS, CXX, CXXFLAGS are taken into account.

The comment is changed but not the script.


More information about the dev mailing list