[dpdk-dev] [PATCH] kernel: remove igb_uio

[Bruce Richardson]

On Tue, Sep 08, 2020 at 11:27:23AM +0200, Thomas Monjalon wrote:
> 08/09/2020 10:25, Bruce Richardson:
> > On Tue, Sep 08, 2020 at 02:14:02AM +0200, Thomas Monjalon wrote:
> > > On Tue Sep 8, 2020 at 2:50 AM CEST, Thomas Monjalon wrote:
> > > > As decided in the Technical Board in November 2019,
> > > > the kernel module igb_uio is moved to the dpdk-kmods repository
> > > > in the /linux/igb_uio/ directory.
> > > 
> > > The code is moved with its git history in
> > > 	http://git.dpdk.org/dpdk-kmods/
> > > 
> > > The move process started with these commands:
> > > 	cd dpdk
> > > 	dir=igb_uio
> > > 	path1=lib/librte_eal/linuxapp/$dir
> > > 	path2=kernel/linux/$dir
> > > 	git format-patch -o $dir 0c9a540ed2.. -- $path1 $path2
> > > 	find $dir -type f -exec sed -i "s,$path1\|$path2,linux/$dir," '{}' \;
> > > 	cd ../dpdk-kmods
> > > 	git am ../dpdk/$dir/*
> > > 	git filter-branch --force
> > > 		--index-filter "git rm --cached --ignore-unmatch linux/$dir/Makefile"
> > > 		--prune-empty --tag-name-filter cat -- --all
> > > 
> > > Makefile and meson.build files were not imported at all.
> > > Some other commits were skipped (virtio, vmxnet3 and Xen dom0 support),
> > > because they were not very useful and reverted later in the history.
> > > Anyway the original history is available forever in dpdk.git.
> > > 
> > > Currently it cannot compile because the file rte_pci_dev_feature_defs.h
> > > is missing, defining enum rte_intr_mode. An option is to import this file.
> > > 
> > > It would be nice to add a README file in the new igb_uio directory.
> > > Volunteers welcome :)
> > 
> > In terms of building the module, one option which I think is worth
> > considering is to try and use meson subject/wrap support to download and
> > build this module as part of the main DPDK build, as now, when enable_kmods
> > option is set. With a wrap file in DPDK it can automatically pull down and
> > build the code as part of a main project build. I assume that integration
> > into main DPDK build is still something worth having? The only thing I
> > don't like about using a wrap file is that it has to be placed in a folder
> > called "subproject" at the top level of the DPDK project.
> 
> The idea is encouraging the use of VFIO and make igb_uio deprecated.
> I think we should not do any effort to ease igb_uio usage inside dpdk.git.
> Compiling the kernel module standalone in dpdk-kmods.git looks enough, isn't it?
> 

Ok, that is fine if that is the objective. I thought the objective was to
move all kernel modules out of the DPDK tree, but if it's only certain
modules, then that is different.

/Bruce