[dpdk-dev] [PATCH v1] app/test-pmd: fix meson build failed when used latency stats lib

[Bruce Richardson]

On Thu, Sep 10, 2020 at 02:20:18AM +0000, SteveX Yang wrote:
> meson build cannot find the header rte_latencystats.h when build DPDK
> first time or never installed DPDK lib after build via meson/ninja.
> 
> Because the corresponding header directory isn't included after enabled
> RTE_LIBRTE_LATENCY_STATS flag.
> 
> Add the header file location and link library to meson.build of test-pmd
> 
> Signed-off-by: SteveX Yang <stevex.yang at intel.com>
> ---

As before, I think we have a mismatch in old vs new macro names which is
why this wasn't caught before. Therefore I suggest we just change testpmd
to use the new macro to keep things standardized. [Other alternatives if we
want to keep compatibility are to rename the latencystats directory to have
an underscore in it, or to override the name (which I'd rather not go for)]

>  app/test-pmd/meson.build | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build
> index db0ff02eb..6ee7af750 100644
> --- a/app/test-pmd/meson.build
> +++ b/app/test-pmd/meson.build
> @@ -9,6 +9,10 @@ if dpdk_conf.has('RTE_LIBRTE_BOND_PMD')
>  	cflags += '-I' + meson.source_root() + '/drivers/net/bonding'
>  endif
>  
> +if dpdk_conf.has('RTE_LIBRTE_LATENCYSTATS')
> +	cflags += '-I' + meson.source_root() + '/lib/librte_latencystats'
> +endif
> +

Rather than working with long cflags, just add latencystats as a dependency
of testpmd.

>  sources = files('5tswap.c',
>  	'cmdline.c',
>  	'cmdline_flow.c',
> -- 
> 2.17.1
>