[dpdk-dev] [PATCH v5 2/2] test/service: fix race condition on stopping lcore

[Van Haaren, Harry]

> -----Original Message-----
> From: David Marchand <david.marchand at redhat.com>
> Sent: Monday, September 14, 2020 9:37 AM
> To: Van Haaren, Harry <harry.van.haaren at intel.com>
> Cc: dev <dev at dpdk.org>; Igor Romanov <igor.romanov at oktetlabs.ru>; Honnappa
> Nagarahalli <honnappa.nagarahalli at arm.com>; Yigit, Ferruh
> <ferruh.yigit at intel.com>; nd <nd at arm.com>; Aaron Conole
> <aconole at redhat.com>; Lukasz Wojciechowski
> <l.wojciechow at partner.samsung.com>; Phil Yang <phil.yang at arm.com>
> Subject: Re: [PATCH v5 2/2] test/service: fix race condition on stopping lcore
> 
> On Fri, Jul 24, 2020 at 3:44 PM Harry van Haaren
> <harry.van.haaren at intel.com> wrote:
> >
> > This commit fixes a potential race condition in the tests
> > where the lcore running a service would increment a counter
> > that was already reset by the test-suite thread. The resulting
> > race-condition incremented value could cause CI failures, as
> > indicated by DPDK's CI.
> >
> > This patch fixes the race-condition by making use of the
> > added rte_service_lcore_active() API, which indicates when
> > a service-core is no longer in the service-core polling loop.
> >
> > The unit test makes use of the above function to detect when
> > all statistics increments are done in the service-core thread,
> > and then the unit test continues finalizing and checking state.
> >
> > Fixes: f28f3594ded2 ("service: add attribute API")
> >
> > Reported-by: David Marchand <david.marchand at redhat.com>
> > Signed-off-by: Harry van Haaren <harry.van.haaren at intel.com>
> > Reviewed-by: Phil Yang <phil.yang at arm.com>
> > Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
> 
> There is still a compilation issue reported by the Intel CI.
> http://mails.dpdk.org/archives/test-report/2020-July/146535.html
> 
> Please fix.

Done, v6 sent; http://patches.dpdk.org/project/dpdk/list/?series=12198