[dpdk-dev] [PATCH] eventdev: add PCI probe named convenience function
Eads, Gage
gage.eads at intel.com
Mon Sep 14 22:22:57 CEST 2020
<snip>
> /**
> * @internal
> + * Wrapper for use by pci drivers as a .probe function to attach to a event
> + * interface.
> + */
> +static inline int
> +rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv,
> + struct rte_pci_device *pci_dev,
> + size_t private_data_size,
> + eventdev_pmd_pci_callback_t devinit)
> +{
> + char eventdev_name[RTE_EVENTDEV_NAME_MAX_LEN];
> +
> +
Two blank lines -- DPDK coding style doesn't forbid this as far as I know
(LINE_SPACING is ignored in checkpatch), but just an FYI in case this was
unintentional.
> + rte_pci_device_name(&pci_dev->addr, eventdev_name,
> + sizeof(eventdev_name));
> +
> + return rte_event_pmd_pci_probe_named(pci_drv,
> + pci_dev,
> + private_data_size,
> + devinit,
> + (const char *)eventdev_name);
Nit: the cast is unnecessary, the conversion will happen implicitly without it.
With that,
Reviewed-by: Gage Eads <gage.eads at intel.com>
More information about the dev
mailing list