[dpdk-dev] [PATCH v2] cmdline: avoid name clash with Windows system types

[Olivier Matz]

Hi,

On Thu, Sep 03, 2020 at 10:40:31AM +0100, Bruce Richardson wrote:
> On Thu, Sep 03, 2020 at 12:30:56PM +0300, Dmitry Kozlyuk wrote:
> > On Thu, 3 Sep 2020 10:20:52 +0100, Bruce Richardson wrote:
> > > On Wed, Sep 02, 2020 at 09:38:05PM +0300, Dmitry Kozlyuk wrote:
> > > > cmdline_numtype member names clash with Windows system identifiers.
> > > > Add CMDLINE_ prefix to cmdline constants to avoid this and possible
> > > > future conflicts.
> > > > 
> > > > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk at gmail.com>
> > > > Suggested-by: Ranjit Menon <ranjit.menon at intel.com>
> > > > ---  
> > > 
> > > Is CMDLINE the best prefix to use here. The DPDK standard is obviously RTE_
> > > as a prefix. This is one I suggested previously (over a year ago, actually):
> > > 
> > > http://patches.dpdk.org/patch/52644/
> > 
> > RTE_ is the standard indeed. I went with CMDLINE_, because this is the prefix
> > librte_cmdline uses for its main routines. Will change in v3 if no objections
> > arise.
> 
> Yes, I suggest waiting for other inputs.

+1 for RTE_ prefix