[dpdk-dev] [PATCH v2] gso: fix pyld_unit_size issue for udp gso

Ferruh Yigit ferruh.yigit at intel.com
Thu Sep 17 17:01:50 CEST 2020


On 9/17/2020 3:16 AM, Hu, Jiayu wrote:

>> -----Original Message-----
>> From: yang_y_yi at 163.com <yang_y_yi at 163.com>
>> Sent: Thursday, September 17, 2020 10:13 AM
>> To: dev at dpdk.org
>> Cc: Hu, Jiayu <jiayu.hu at intel.com>; thomas at monjalon.net;
>> yangyi01 at inspur.com; yang_y_yi at 163.com
>> Subject: [PATCH v2] gso: fix pyld_unit_size issue for udp gso
>>
>> From: Yi Yang <yangyi01 at inspur.com>
>>
>> Fragment offset of IPv4 header is measured in units of
>> 8 bytes. Fragment offset of UDP fragments will be wrong
>> after GSO if pyld_unit_size isn't multiple of 8. Say
>> pyld_unit_size is 1500, fragment offset of the second
>> UDP fragment will be 187 (i.e. 1500 / 8), which means 1496,
>> and it will result in 4-byte data loss (1500 - 1496 = 4).
>> So UDP GRO will reassemble out a wrong packet.
>>
>> Fixes: b166d4f30b66 ("gso: support UDP/IPv4 fragmentation")
>>
>> Signed-off-by: Yi Yang <yangyi01 at inspur.com>
>
 > Acked-by: Jiayu Hu <jiayu.hu at intel.com>
 >

Applied to dpdk-next-net/main, thanks.



More information about the dev mailing list