[dpdk-dev] [PATCH] crypto/scheduler: fix header install with meson

Bruce Richardson bruce.richardson at intel.com
Thu Sep 17 17:29:20 CEST 2020


On Thu, Sep 17, 2020 at 05:09:17PM +0200, David Marchand wrote:
> The headers variable is only used in lib/meson.build context.
> For drivers, an explicit install_headers() is necessary.
> 
> Reproduced while compiling the l2fwd-crypto example out of meson
> (which can be done by adding it in devtools/test-meson-builds.sh
> examples build test).
> 
> Fixes: cd2b6458a1cb ("crypto/scheduler: add in meson build")
> Cc: stable at dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand at redhat.com>
> ---
>  drivers/crypto/scheduler/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
Originally I only put the "headers" variable in the "lib" folder
meson.build because it was not expected that many drivers should have
private headers. However, perhaps it's worthwhile adding it now:
a) because private headers, while not common, are not unusual
b) for consistency and ease of use.

Thoughts?

/Bruce


More information about the dev mailing list