[dpdk-dev] [PATCH v11 00/24] ethdev: allow unknown link speed

Ferruh Yigit ferruh.yigit at intel.com
Fri Sep 18 20:47:37 CEST 2020


On 9/18/2020 6:23 PM, Ferruh Yigit wrote:
> On 9/15/2020 8:06 PM, Ivan Dyukov wrote:
> <...>
> 
>>
>> v11 changes:
>> * 0 Mbps =>  None
>> * Invalid speed => Invalid
>> * Change code style of rte_eth_link_speed_to_str
>>
>> v10 changes:
>> * remove format string arg from rte_eth_link_to_str function
>> * add rte_eth_link_speed_to_str function
>> * add usage of rte_eth_link_speed_to_str in examples
>>
>> v9 changes:
>> * remove rte_eth_link_printf function
>> * add ETH_LINK_MAX_STR_LEN definition
>> * add usage of ETH_LINK_MAX_STR_LEN in examples
>>
>> v8 changes:
>> * rename rte_eth_link_strf to rte_eth_link_to_str
>> * refactor rte_eth_link_to_str according to review comments
>> * fix codestyle
>> * fix commit message in 02 patch
>> * fix compile error in ntb application
>> * merge "app" and "doc" commits
>>
>> v7 changes:
>> * fix meson build
>> * change _strf function. now it does not fails in case of unknown 
>> specifiers like %d. it just copy it to target string.
>> * remove invalid_fmt unit test.
>> * add unknown specifier test.
>> * fix codestyle
>>
>> v6 changes:
>> * fix spelling in comments according to checkpatch warning
>>
>> v5 changes:
>> * rename rte_eth_link_format to rte_eth_link_strf
>> * add '\n' to default strings
>> * update remaining examples. patch with subj 'examples: new link 
>> status print format' contains examples which have no maintainers.
>> TBD:
>> update remaining nic drivers with 'unknown' speed.  It should be 
>> provided in separate patchset.
>>
>> v4 changes:
>> * refactor rte_eth_link_format using strlcat func instead of snprintf
>> * added new checks to unit tests
>> * few minor fixes according review comments
>> TBD:
>> update examples in 'example' folder with new status printing mechanism
>> update remaining nic drivers with 'unknown' speed
>>
>> v3 changes:
>> * remove rte_eth_link_prepare_text function
>> * add rte_eth_link_format and rte_eth_link_printf functions
>> * added unit tests for rte_eth_link_format function
>> TBD:
>> update examples in 'example' folder with new status printing mechanism
>> update remaining nic drivers with 'unknown' speed
>>
>> v2 changes:
>> * add function which format link status to textual representation
>> * update drivers for Intel nics with 'unknown' speed
>> TBD:
>> update examples in 'example' folder with new status printing mechanism
>> update remaining nic drivers with 'unknown' speed
>>
>> v1 changes:
>> This is initial patchset which introduces UNKNOWN speed to dpdk
>> applications. Also it contains changes related to printf formating.
>> Patchset contains changes for app/ and doc/ folders.
>> examples/ folder will be provided later.
>>
>>
> 
> The ethdev patch introduces 'ETH_SPEED_NUM_UNKNOWN' and driver patches 
> were already merged from previous version. Will get the remaining ones.
 >

For series,
Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>

The comments on the patches fixed while merging.

All example patches squashed into single commit.


Series applied to dpdk-next-net/main, thanks.


More information about the dev mailing list