[dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for rte_epoll_event

wangyunjian wangyunjian at huawei.com
Sat Sep 19 12:42:30 CEST 2020


Friendly ping.

> -----Original Message-----
> From: wangyunjian
> Sent: Wednesday, August 26, 2020 6:56 PM
> To: dev at dpdk.org; hkalra at marvell.com; david.marchand at redhat.com
> Cc: 'ferruh.yigit at intel.com' <ferruh.yigit at intel.com>; 'Thomas Monjalon'
> <thomas at monjalon.net>; Lilijun (Jerry) <jerry.lilijun at huawei.com>; xudingke
> <xudingke at huawei.com>; stable at dpdk.org
> Subject: RE: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for
> rte_epoll_event
> 
> Ping for review, please.
> 
> > -----Original Message-----
> > From: wangyunjian
> > Sent: Wednesday, July 15, 2020 10:40 AM
> > To: dev at dpdk.org; hkalra at marvell.com
> > Cc: Lilijun (Jerry) <jerry.lilijun at huawei.com>; xudingke
> > <xudingke at huawei.com>; wangyunjian <wangyunjian at huawei.com>;
> > stable at dpdk.org
> > Subject: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for
> > rte_epoll_event
> >
> > From: Yunjian Wang <wangyunjian at huawei.com>
> >
> > The "rev->epdata.event" assigned to "events.epdata.event" directly,
> > which was wrong in case of epoll events. It should be set to the "evs.events".
> >
> > Fixes: 9efe9c6cdcac ("eal/linux: add epoll wrappers")
> > Cc: stable at dpdk.org
> >
> > Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
> > ---
> >  lib/librte_eal/linux/eal_interrupts.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/librte_eal/linux/eal_interrupts.c
> > b/lib/librte_eal/linux/eal_interrupts.c
> > index 13db5c4e8..8a3c95cec 100644
> > --- a/lib/librte_eal/linux/eal_interrupts.c
> > +++ b/lib/librte_eal/linux/eal_interrupts.c
> > @@ -1237,7 +1237,7 @@ eal_epoll_process_event(struct epoll_event *evs,
> > unsigned int n,
> >  		events[count].status        = RTE_EPOLL_VALID;
> >  		events[count].fd            = rev->fd;
> >  		events[count].epfd          = rev->epfd;
> > -		events[count].epdata.event  = rev->epdata.event;
> > +		events[count].epdata.event  = evs[i].events;
> >  		events[count].epdata.data   = rev->epdata.data;
> >  		if (rev->epdata.cb_fun)
> >  			rev->epdata.cb_fun(rev->fd,
> > --
> > 2.23.0
> >



More information about the dev mailing list