[dpdk-dev] [PATCH v4 00/41] Pipeline alignment with the P4 language

[David Marchand]

On Wed, Sep 23, 2020 at 6:08 PM Dumitrescu, Cristian
<cristian.dumitrescu at intel.com> wrote:
> > - Many MACRO_WITH_FLOW_CONTROL warnings reported by checkpatches.
> >
>
> Yes, I fixed all the other code style issues, this is the only one remaining. It is basically due to a recurring CHECK() macro. And it will also ripples over the code, so IMO it is time consuming & error prone to remove with no real benefit.
>
> We also already have many places in DPDK that use the same pattern. I suggest we ignore this warning, are you OK with it?

I am fine with ignoring, this is not like we have no other occurrence
of such macros.
I still see little value in those specific macros.


> > - On the patch titles, check-git-log.sh reports:
> > Wrong headline case:
> >             "pipeline: add SWX dma instruction": dma --> DMA
> > Wrong headline case:
> >             "pipeline: add SWX rx and extract instructions": rx --> Rx
> > Wrong headline case:
> >             "pipeline: add SWX tx and emit instructions": tx --> Tx
> > Wrong headline case:
> >             "pipeline: introduce SWX xor instruction": xor --> XOR
> >
>
> I can do this change, but IMO it is not the right choice here, as in this particular case we have instructions that are called "rx", "tx", "dma", "and", "or", "xor", etc. So it is the name of an instruction rather than a text abbreviation. Hence, I think these messages are not really applicable here. What do you think?

For this reason I am ok with ignoring too, Thomas wdyt?


-- 
David Marchand