[dpdk-dev] [EXT] Re: [RFC PATCH] app/testpmd: tx pkt clones parameter in flowgen

Igor Russkikh irusskikh at marvell.com
Fri Sep 25 10:44:51 CEST 2020


>> +		} else {
>> +			nb_clones--;
>> +		}
>> +		pkts_burst[nb_pkt] = pkt;
>>  
>>  		next_flow = (next_flow + 1) % cfg_n_flows;
>>  	}
> 
> 
> This doesn't look safe. You can't just send same mbuf N times without
> incrementing
> the reference count.

Hi Stephen,

You are right, of course we need refcnt increment here.

It looks like it worked for me, because occasionally its possible to execute
rte_pktmbuf_free multiple times over mbuf with refcnt==1 without any immediate
side effects.

Will repost.

Thanks,
  Igor


More information about the dev mailing list