[dpdk-dev] [PATCH v2 03/12] acl: remove of unused enum value
Ruifeng Wang
Ruifeng.Wang at arm.com
Sun Sep 27 05:27:56 CEST 2020
> -----Original Message-----
> From: Konstantin Ananyev <konstantin.ananyev at intel.com>
> Sent: Wednesday, September 16, 2020 12:50 AM
> To: dev at dpdk.org
> Cc: jerinj at marvell.com; Ruifeng Wang <Ruifeng.Wang at arm.com>;
> vladimir.medvedkin at intel.com; Konstantin Ananyev
> <konstantin.ananyev at intel.com>
> Subject: [PATCH v2 03/12] acl: remove of unused enum value
>
> Removal of unused enum value (RTE_ACL_CLASSIFY_NUM).
> This enum value is not used inside DPDK, while it prevents to add new
> classify algorithms without causing an ABI breakage.
>
> Note that this change introduce a formal ABI incompatibility with previous
> versions of ACL library.
>
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev at intel.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 4 ----
> doc/guides/rel_notes/release_20_11.rst | 4 ++++
> lib/librte_acl/rte_acl.h | 1 -
> 3 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index 52168f775..3279a01ef 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -288,10 +288,6 @@ Deprecation Notices
> - https://patches.dpdk.org/patch/71457/
> - https://patches.dpdk.org/patch/71456/
>
> -* acl: ``RTE_ACL_CLASSIFY_NUM`` enum value will be removed.
> - This enum value is not used inside DPDK, while it prevents to add new
> - classify algorithms without causing an ABI breakage.
> -
> * sched: To allow more traffic classes, flexible mapping of pipe queues to
> traffic classes, and subport level configuration of pipes and queues
> changes will be made to macros, data structures and API functions defined
> diff --git a/doc/guides/rel_notes/release_20_11.rst
> b/doc/guides/rel_notes/release_20_11.rst
> index b729bdf20..a9a1b0305 100644
> --- a/doc/guides/rel_notes/release_20_11.rst
> +++ b/doc/guides/rel_notes/release_20_11.rst
> @@ -97,6 +97,10 @@ API Changes
> and the function ``rte_rawdev_queue_conf_get()``
> from ``void`` to ``int`` allowing the return of error codes from drivers.
>
> +* acl: ``RTE_ACL_CLASSIFY_NUM`` enum value has been removed.
> + This enum value was not used inside DPDK, while it prevented to add
> +new
> + classify algorithms without causing an ABI breakage.
> +
>
> ABI Changes
> -----------
> diff --git a/lib/librte_acl/rte_acl.h b/lib/librte_acl/rte_acl.h index
> aa22e70c6..b814423a6 100644
> --- a/lib/librte_acl/rte_acl.h
> +++ b/lib/librte_acl/rte_acl.h
> @@ -241,7 +241,6 @@ enum rte_acl_classify_alg {
> RTE_ACL_CLASSIFY_AVX2 = 3, /**< requires AVX2 support. */
> RTE_ACL_CLASSIFY_NEON = 4, /**< requires NEON support. */
> RTE_ACL_CLASSIFY_ALTIVEC = 5, /**< requires ALTIVEC support. */
> - RTE_ACL_CLASSIFY_NUM /* should always be the last one. */
> };
>
> /**
> --
> 2.17.1
Looks good from ABI perspective.
Reviewed-by: Ruifeng Wang <ruifeng.wang at arm.com>
More information about the dev
mailing list