[dpdk-dev] [PATCH v3 00/29] cleanup ethdev close operation

Ferruh Yigit ferruh.yigit at intel.com
Wed Sep 30 14:22:28 CEST 2020


On 9/29/2020 12:14 AM, Thomas Monjalon wrote:
> This is the end of a process started two years ago,
> to have a close which reliably releases an ethdev port
> without the need of removing the device (which can have more ports).
> 
> Unfortunately, some drivers might be broken because did not follow
> the migration recommendations. We cannot wait more,
> this should be merged before the 20.11-rc1 release.
> 
> 
> v3:
>    - integrate NXP patches for dpaa, dpaa2, enetc and pfe
>    - fix crash in rte_eth_dev_release_port() because of early memset 0
> 
> v2 (big thanks to Ferruh for the reviews):
>    - rebase on top of cxgbe updates
>    - integrate updated patches for tap, bnx2x, qede
>    - return 0 in atlantic PMD
>    - fix failsafe mutex free
>    - remove useless check in pcap
>    - fix testpmd port state transition
>    - add primary process check
>    - reset more pointers in rte_eth_dev_release_port()
>    - remove dev_started reset in rte_eth_dev_close()
>    - return int from rte_eth_dev_close()
> 
> Note for future: fix old memory leak when releasing port,
> i.e. free callbacks link_intr_cbs, post_rx_burst_cbs, pre_tx_burst_cbs.
> 
> The last 3 patches are optional changes to ethdev close/release
> which were requested by Ferruh but may take longer to be accepted:
>    - memset 0
>    - keep start state
>    - int return
> 
> 
> Rasesh Mody (2):
>    net/bnx2x: release port upon close
>    net/qede: release port upon close
> 
> Sachin Saxena (4):
>    net/dpaa: release port upon close
>    net/dpaa2: release port upon close
>    net/enetc: release port upon close
>    net/pfe: release port upon close
> 
> Thomas Monjalon (22):
>    ethdev: reset device and interrupt pointers on release
>    ethdev: allow drivers to return error on close
>    net/af_packet: release port upon close
>    net/atlantic: release port upon close
>    net/axgbe: release port upon close
>    net/bonding: release port upon close
>    net/failsafe: release port upon close
>    net/mlx4: release port upon close
>    net/null: release port upon close
>    net/octeontx: release port upon close
>    net/pcap: release port upon close
>    net/ring: release port upon close
>    net/softnic: release port upon close
>    ethdev: remove old close behaviour
>    drivers/net: accept removing device without any port
>    drivers/net: check process type in close operation
>    drivers/net: remove redundant MAC addresses freeing
>    app/testpmd: reset port status on close notification
>    app/testpmd: align behaviour of multi-port detach
>    ethdev: remove forcing stopped state upon close
>    ethdev: reset all when releasing a port
>    ethdev: allow close function to return an error
> 
> Yunjian Wang (1):
>    net/tap: release port upon close
> 


Since some discussions going on them last three patches not merged, they can be 
sent separately.

Except from last three patches, 27/29, 28/29, 29/29,
Series applied to dpdk-next-net/main, thanks.



More information about the dev mailing list