[dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version

[Bruce Richardson]

On Tue, Mar 23, 2021 at 09:38:25AM +0000, Bruce Richardson wrote:
> On Tue, Mar 23, 2021 at 07:22:00AM +0100, Gabriel Ganne wrote:
> >    Hi,
> >    Thanks for the review.
> >    I have some reservations about those TODO: they are about
> >    rewriting the same functionality with a newer meson feature.
> >    No functional change is expected. => Why not write a commit that
> >    implements such a TODO and bumps meson version at the same time
> >    independently ?
> >    In any case, I aimed to set meson's required version to the lowest
> >    possible value
> >    so that distributions would have a chance to provide it. I know we can
> >    just
> >    install meson using pip, but it might be nice not to need this.
> >    Below are some versions of meson packages as of today:
> >      pip: 0.57.1
> >      rhel-8: 0.49.2
> >      debian-10: 0.49.2
> >      ubuntu-18.04: 0.45.1
> >      ubuntu-20.04: 0.53.2
> >    Going over 0.49.2 will cause DPDK to lose some major distribution's
> >    stable release,
> >    at least out-of-the-box through their respective package manager.
> >    I propose to bump to 0.49.2 here, and leave the TODOs to wait a little
> >    longer.
> 
> +1
> However, I don't think we need the ".2" specifically, since new features
> don't come in point releases, so I'd suggest just making "0.49" the
> minimum.

To partially contradict myself here, there is a bug[1] present in earlier
releases of meson which can affect building OVS and apps using pkg-config
for DPDK. This has been fixed[2] in 0.50 release onwards, but also backported
to meson 0.49.1. Therefore, for sanity, we may indeed want to bump the
version to 0.49.1 (or .2 if you like) rather than 0.49 as I suggested here.

/Bruce

[1] https://github.com/mesonbuild/meson/issues/4091
[2] https://github.com/mesonbuild/meson/commit/261ab9b2140005d4f7e42118ccb6598fa5b7f15d