[dpdk-dev] [RFC PATCH 05/14] build: clean up driver list indentation

Bruce Richardson bruce.richardson at intel.com
Thu Apr 1 14:33:39 CEST 2021


On Thu, Apr 01, 2021 at 03:14:40PM +0300, Andrew Rybchenko wrote:
> On 4/1/21 2:50 PM, Bruce Richardson wrote:
> > Ensure all lists of drivers are one-per-line and replace tabs with spaces
> > in each file to correspond to the new standard.
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
> > ---
> >  drivers/baseband/meson.build |   8 ++-
> >  drivers/bus/meson.build      |   7 ++-
> >  drivers/common/meson.build   |   9 +++-
> >  drivers/compress/meson.build |   7 ++-
> >  drivers/crypto/meson.build   |  38 ++++++-------
> >  drivers/event/meson.build    |  17 ++++--
> >  drivers/mempool/meson.build  |   8 ++-
> >  drivers/meson.build          |  33 ++++++------
> >  drivers/net/meson.build      | 102 +++++++++++++++++------------------
> >  drivers/raw/meson.build      |  15 +++---
> >  drivers/regex/meson.build    |   3 +-
> >  drivers/vdpa/meson.build     |   4 +-
> >  12 files changed, 142 insertions(+), 109 deletions(-)
> > 
> > diff --git a/drivers/baseband/meson.build b/drivers/baseband/meson.build
> > index 920e3b02ee..22d0036cd7 100644
> > --- a/drivers/baseband/meson.build
> > +++ b/drivers/baseband/meson.build
> > @@ -2,7 +2,11 @@
> >  # Copyright(c) 2018 Luca Boccassi <bluca at debian.org>
> >  
> >  if is_windows
> > -	subdir_done()
> > +    subdir_done()
> >  endif
> >  
> > -drivers = ['null', 'turbo_sw', 'fpga_lte_fec', 'fpga_5gnr_fec', 'acc100']
> > +drivers = ['null',
> > +        'turbo_sw',
> > +        'fpga_lte_fec',
> > +        'fpga_5gnr_fec',
> > +        'acc100']
> 
> It looks like it is more than 4 spaces here (and many similar
> cases below), but previous patch and longs lists below in the
> file use 4 spaces alignment.

Yes, for indenting line continuations, I've tended to prefer to use a
double-indent, and save single indent for new blocks of code.


More information about the dev mailing list