[dpdk-dev] [PATCH v1] lib/hash: support non sse42 cpu architecture

[Amber, Kumar]

Hi Thomas ,

Pls reject it 

-----Original Message-----
From: Thomas Monjalon <thomas at monjalon.net> 
Sent: Friday, April 9, 2021 4:12 AM
To: Amber, Kumar <kumar.amber at intel.com>
Cc: Wang, Yipeng1 <yipeng1.wang at intel.com>; dev at dpdk.org; Richardson, Bruce <bruce.richardson at intel.com>; Gobriel, Sameh <sameh.gobriel at intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] lib/hash: support non sse42 cpu architecture

25/03/2021 09:06, Thomas Monjalon:
> 24/03/2021 23:59, Wang, Yipeng1:
> > From: kumar amber
> > > 
> > > add _SSE42_ flag to enable compilation of
> > > sse42 specific instructions only on supported architecture
> > > 
> > > Signed-off-by: kumar amber <kumar.amber at intel.com>
[...]
> > [Wang, Yipeng] 
> > Hi, Kumar, thanks for the patch.
> > I think the minimum required machine for x86 is sse4.2 compatible already. So I wonder if we really need this.
> 
> Yes, that's why I don't understand this patch.

Any comment? Should we reject the patch?